Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.0.0a api fix #2 - refix the broken API pipeline #480

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

yuchen1984
Copy link
Contributor

@yuchen1984 yuchen1984 commented Mar 21, 2024

The commit of #468 seems to break the APi pipelines again.

The primary cause of the problem is that "setattr" sections cannot be removed as those extra attributes don't exist in the default ControlNetUnit class defined in sd-webui-controlnet, and "setattr" will add the new attributes (which only exist in the UiControlNet class) to the object in a hacky way. To remove them, there will need to be a change in the sd-webui-control which I don't bother to make right now.

Another bug is that the return of the get_controlnet_units should be cn_units_dataclass (a list of ControlNetUnit) when is_api is True

Now it can also handle the ip-adapter case (which takes a single reference image rather than batch images) together with other control net based on batch frame-wise input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant